Skip to content

Conversation

simonsarginson
Copy link
Collaborator

No description provided.

@improbable-prow-robot improbable-prow-robot added the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label May 25, 2021
@simonsarginson simonsarginson self-assigned this May 25, 2021
@improbable-prow-robot improbable-prow-robot added the size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. label May 25, 2021
GDK_BRANCH: ""${GDK_BRANCH:-match_branch_name_pref::0.13.1-rc}"
ENGINE_BRANCH: "${ENGINE_BRANCH_426:-match_branch_name_pref_engine::4.26-SpatialOSUnrealGDK-0.13.1-rc}"
ENGINE_MAJOR: "4.26"
PROJECT_BRANCH: "${BUILDKITE_BRANCH}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PROJECT_BRANCH: "${BUILDKITE_BRANCH}"
PROJECT_BRANCH: "main_branch::${BUILDKITE_BRANCH}"

GDK_BRANCH: ""${GDK_BRANCH:-match_branch_name_pref::0.13.1-rc}"
ENGINE_BRANCH: "${ENGINE_BRANCH_426:-match_branch_name_pref_engine::4.26-SpatialOSUnrealGDK-0.13.1-rc}"
ENGINE_MAJOR: "4.26"
PROJECT_BRANCH: "${BUILDKITE_BRANCH}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PROJECT_BRANCH: "${BUILDKITE_BRANCH}"
PROJECT_BRANCH: "main_branch::${BUILDKITE_BRANCH}"

@mironec mironec self-requested a review May 25, 2021 15:11
@simonsarginson simonsarginson merged commit 3125cc5 into 0.13.1-rc May 25, 2021
@improbable-prow-robot improbable-prow-robot deleted the feature/bring-13.1-rc-up-to-ci-1.2 branch May 25, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants